Final changes of merges #18
Conversation
# Conflicts: # KJ1124/Thor_Puzzle_assign.c
KJ1124/Thor_Puzzle_assign.c
Outdated
| int light_y; // the Y position of the light of power | ||
| int initial_tx; // Thor's starting X position | ||
| int initial_ty; // Thor's starting Y position | ||
| cin >> light_x >> light_y >> initial_tx >> initial_ty; cin.ignore(); |
There was a problem hiding this comment.
Explain this line -- what does it do? Why is it here?
KJ1124/Thor_Puzzle_assign.c
Outdated
| while (1) { | ||
|
|
||
|
|
||
| int remaining_turns; // The remaining amount of turns Thor can move. Do not remove this line. |
There was a problem hiding this comment.
Put the comment on the previous line, so it will be rendered by CodeChat.
|
|
||
|
|
||
| int remaining_turns; // The remaining amount of turns Thor can move. Do not remove this line. | ||
| cin >> remaining_turns; cin.ignore(); |
There was a problem hiding this comment.
Explain. Why do this? Why ignore?
KJ1124/Thor_Puzzle_assign.c
Outdated
| ---------------- | ||
| **Based on the position light of power I first determined which direction he would travel and then developed this code on the basis of each test code.** | ||
|
|
||
| **Test case 1 & 2:** |
There was a problem hiding this comment.
Remove your notes on each test case, and instead focus on how to solve the overall problem. I like instructions on how to run the tests cases, though -- leave that.
KJ1124/Thor_Puzzle_assign.c
Outdated
| Code for Movement | ||
| ------------------ | ||
| */ | ||
| // **this is the fourth test case...** |
There was a problem hiding this comment.
Put comments explaining what this line does right here, rather than in the preceding paragraphs.
KJ1124/Thor_Puzzle_assign.c
Outdated
| initial_ty++; | ||
| } | ||
| // **This is the first test case below...** | ||
| else if(light_x > initial_tx) { |
There was a problem hiding this comment.
Why do all the other cases only have one comparison? There's no way to go NE, for example.
KJ1124/Thor_Puzzle_assign.c
Outdated
| } | ||
| // **Don't forget to include the "else{}" statment at the end.** | ||
| else{}; | ||
| } |
There was a problem hiding this comment.
Fix spacing -- all the code should be indented, so that each bracket is has its own horizontal position.
|
Resubmit by midnight, 3-Mar. |
|
I haven't seen any progress on this... |
|
Is this superseded by #22? |
2 participants
This is my final changes to my code with peters comments and Dr. Jones notes aswell